Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packit: update packit targets #2341

Merged
merged 1 commit into from
May 29, 2024
Merged

Packit: update packit targets #2341

merged 1 commit into from
May 29, 2024

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented May 29, 2024 •
edited
Loading

We only care about buildability on epel 9 (RHEL). It won't be shipped to centos stream or to fedora.

@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@lsm5 lsm5 force-pushed the release-1.14-packit-update branch from 192846b to 045a9dd Compare May 29, 2024 13:18
@lsm5
Copy link
Member Author

lsm5 commented May 29, 2024 •
edited
Loading

c9s failing on

# github.com/containers/libtrust
vendor/github.com/containers/libtrust/ec_key_openssl.go:23:9: not enough return values
	have ([]byte, error)
	want (*big.Int, *big.Int, error)

rawhide failures are a rawhide problem, should apparently be resolved soon.

@lsm5
Copy link
Member Author

lsm5 commented May 29, 2024

I think these should just be epel targets. Updating..

@lsm5
Packit: update packit targets
3781db8 
We only care about buildability on epel 9 (RHEL). It won't be shipped to
centos stream or to fedora.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the release-1.14-packit-update branch from 045a9dd to 3781db8 Compare May 29, 2024 14:34
@mtrmac
Copy link
Contributor

mtrmac commented May 29, 2024 

vendor/github.com/containers/libtrust/ec_key_openssl.go:23:9: not enough return values

For the record, the ecdsa.HashSign function (which has missing for a time) was recently restored with a different prototype. That was later fixed in golang-fips/go#199 .

mtrmac
mtrmac approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mtrmac
Copy link
Contributor

mtrmac commented May 29, 2024

To double check, ideally this should be merged before #2337, is that correct?

@mtrmac mtrmac mentioned this pull request May 29, 2024
Merged
@lsm5 lsm5 marked this pull request as ready for review May 29, 2024 17:51
@lsm5
Copy link
Member Author

lsm5 commented May 29, 2024

To double check, ideally this should be merged before #2337, is that correct?

@mtrmac That's right

@lsm5
Copy link
Member Author

lsm5 commented May 29, 2024

I set these to epel because we don't care about shipping this to centos-stream and fedora AFAIK

@mtrmac mtrmac merged commit d3b91fd into containers:release-1.14 May 29, 2024
10 checks passed
@lsm5 lsm5 deleted the release-1.14-packit-update branch May 29, 2024 18:07
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtrmac mtrmac mtrmac approved these changes

Assignees
No one assigned
Labels
locked - please file new issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsm5 @mtrmac